Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ws is already closed error #9041

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 12, 2022

Description

image

When server was stopped, WebSocket is already in CLOSING or CLOSED state error was happening.
This PR removes that.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jul 12, 2022
@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 9951d98
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cce1c8f6134a00084bade9

@patak-dev patak-dev merged commit 45b8b53 into vitejs:main Jul 12, 2022
@sapphi-red sapphi-red deleted the fix/remove-ws-already-closed branch July 12, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants