fix: support vite client in safari 13 #9315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #9190 (comment)
Our baseline supports Safari 13, which doesn't support optional chaining. Since
vite/client
is served unbundled, we should also support Safari 13. Changing the typescript compile target toes2019
fromes2020
(declared intsconfig.base.json
), transpile the optional chaining usage.cc @Amareis
Additional context
Diff of new vs old
client.mjs
:What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).