Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use browser field if it is not likely UMD or CJS (fixes #9445) #9459

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

sapphi-red
Copy link
Member

Description

When the following conditions were met, browser field was not used.

  • (the package does not have exports field)
  • (Non-SSR build or SSR build for WebWorker)
  • the package has both both browser field and module field
  • browser field is not likely UMD or CJS (the file does not include typeof exports or typeof module or module.exports)

fixes #9445

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 31, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Looks like the logic doesn't do what the comment said.

@patak-dev patak-dev merged commit c868e64 into vitejs:main Aug 10, 2022
@sapphi-red sapphi-red deleted the fix/browser-field-and-module-field branch August 11, 2022 06:53
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build or serve application that imports @aws/sdk packages
3 participants