-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip undefined proxy entry #9622
Conversation
Please don't remove the PR template. When does this happen? IIUC when the config is like below? export default defineConfig({
server: {
proxy: {
'/api': undefined
}
}
} In that case, I think it's better to skip from here with vite/packages/vite/src/node/server/middlewares/proxy.ts Lines 40 to 45 in 70b4baa
Then, we won't need to check if the value is undefined or not in
|
|
@lbiceman, following up in case you're waiting for us here. I think you should implement @sapphi-red suggestion to move this PR forward. if you are busy, don't worry, we'll modify the PR at one point and merge it. Thanks again! |
|
fix(vite/node): Cannot read properties of undefined: configure