Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos in comments and documentation #9711

Merged
merged 5 commits into from
Aug 17, 2022
Merged

docs: fix typos in comments and documentation #9711

merged 5 commits into from
Aug 17, 2022

Conversation

hiro0218
Copy link
Contributor

@hiro0218 hiro0218 commented Aug 17, 2022 •
edited
Loading

Description

fix typo to comment and document

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@hiro0218 hiro0218 changed the title fix typo to comment and document fix(typo): comment and document Aug 17, 2022
bluwy
bluwy previously requested changes Aug 17, 2022
View reviewed changes
packages/vite/CHANGELOG.md Outdated Show resolved Hide resolved
packages/vite/CHANGELOG.md Outdated Show resolved Hide resolved
packages/vite/CHANGELOG.md Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 suggested changes Aug 17, 2022
View reviewed changes
packages/vite/CHANGELOG.md Outdated Show resolved Hide resolved
packages/vite/CHANGELOG.md Outdated Show resolved Hide resolved
packages/vite/CHANGELOG.md Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested a review from bluwy August 17, 2022 09:59
@Shinigami92
Copy link
Member

@patak-dev theoretically we could use .git-blame-ignore-revs for something like this change, but on the other side I don't mind to give a contributor credits for fixing typos as this is also a valid and welcome fix 🤷

@Shinigami92 Shinigami92 added the documentation Improvements or additions to documentation label Aug 17, 2022
@Shinigami92 Shinigami92 changed the title fix(typo): comment and document docs: fix typos in comments and documentation Aug 17, 2022
@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Aug 17, 2022
@patak-dev patak-dev enabled auto-merge (squash) August 17, 2022 10:08
@patak-dev patak-dev merged commit 0571232 into vitejs:main Aug 17, 2022
@hiro0218 hiro0218 deleted the fix/typo branch August 17, 2022 10:24
@hiro0218
Copy link
Contributor Author

I apologize for any inconvenience my inadequate response may have caused. I appreciate your response! I wish "vite" all the best in its development✨

@Shinigami92
Copy link
Member

I apologize for any inconvenience my inadequate response may have caused. I appreciate your response! I wish "vite" all the best in its development✨

Oh, what? Why you think it was inadequate?
Everything is fine, fixing typos like this is very welcome 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@bluwy bluwy Awaiting requested review from bluwy

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiro0218 @Shinigami92 @bluwy @patak-dev