fix: throw missing name error only when 'umd' or 'iife' are used #9886
+129
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
changed the title
sapphi-red
added
p2-nice-to-have
sapphi-red
reviewed
Sep 1, 2022
packages/vite/src/node/build.ts
Outdated
Comment on lines
676
to
826
| outputs.forEach((output) => { | ||
| if (['umd', 'iife'].includes(output.format!) && !output.name) { | ||
| throw new Error( | ||
| 'Entries in "build.rollupOptions.output" must specify "name" when output formats include "umd" or "iife".' | ||
| ) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Rollup does output the following error during build. But I think it's good to have this, because this will output the error before build.
vite v3.1.0-beta.0 building for production...
✓ 1 modules transformed.
dist/index.html 0.76 KiB
dist/my-lib-custom-filename.mjs 0.59 KiB / gzip: 0.36 KiB
You must supply "output.name" for UMD bundles that have exports so that the exports are accessible in environments without a module loader.
davidmyersdev
force-pushed
the
fix-formats-name-warning
branch
from
ddeb27f
to
6f47bbb
Compare
|
Thanks for the feedback, @sapphi-red! I made the updates you requested. |
sapphi-red
previously approved these changes
Sep 3, 2022
|
Do you want me to resolve these conflicts, or will this likely be waiting a while longer before being merged? |
|
Sorry for taking time. It would be great if you could resolve the conflict. |
|
Not a problem. I'll get those resolved soon. |
davidmyersdev
force-pushed
the
fix-formats-name-warning
branch
from
6f47bbb
to
c74870c
Compare
davidmyersdev
force-pushed
the
fix-formats-name-warning
branch
from
c74870c
to
b796284
Compare
sapphi-red
approved these changes
Nov 8, 2022
patak-dev
approved these changes
Nov 8, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
build.rollupOptions.outputis an array, Vite throws the following error if you don't specifybuild.lib.nameeven whenumdandiifeformats are not present. This is because the default forbuild.lib.formatsis['es', 'umd'], and the code does not currently take thebuild.rollupOptions.outputvalue into account until after the error-throwing check is run.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).