Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): spread lightningcss options #14313

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix(css): spread lightningcss options #14313

merged 2 commits into from
Sep 8, 2023

Conversation

ArnaudBarre
Copy link
Member

@ArnaudBarre ArnaudBarre commented Sep 6, 2023

Re-apply fix of #14024 after revert from #14209

After second though style attributes are a very narrow edge case for assets and I don't think it's good that some config can impact the build based on the optional presence of url( in it.

@stackblitz
Copy link

stackblitz bot commented Sep 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node20 ci is failing on nodejs/node#49497

@bluwy bluwy merged commit 80c6608 into main Sep 8, 2023
10 of 11 checks passed
@bluwy bluwy deleted the lightningcss-spread branch September 8, 2023 05:45
Gaubee pushed a commit to Gaubee/vite that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants