revert: "fix(css): spread lightningcss options (#14024)" #14209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of not bundling types and users will get
any
for lightningcss if not installed was good. But this breaks for all users that don't enableskipLibCheck
, and we can't impose people to disable it because it can sometimes catch real issues (like it did for Lightning CSS changes for the features flags options)I will do another PR to fix the underlying issue of missing options spread which will be a lot smaller.
cc @dominikg