Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(css): spread lightningcss options (#14024)" #14209

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

ArnaudBarre
Copy link
Member

The idea of not bundling types and users will get any for lightningcss if not installed was good. But this breaks for all users that don't enable skipLibCheck, and we can't impose people to disable it because it can sometimes catch real issues (like it did for Lightning CSS changes for the features flags options)

I will do another PR to fix the underlying issue of missing options spread which will be a lot smaller.

cc @dominikg

@stackblitz
Copy link

stackblitz bot commented Aug 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ArnaudBarre ArnaudBarre changed the title Revert "fix(css): spread lightningcss options (#14024)" revert: "fix(css): spread lightningcss options (#14024)" Aug 27, 2023
@dominikg
Copy link
Contributor

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Aug 27, 2023

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ❌ failure
ladle ❌ failure
laravel ✅ success
marko ✅ success
nuxt ✅ success
nx ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
unocss ❌ failure
vite-plugin-pwa ✅ success
vite-plugin-ssr ❌ failure
vite-plugin-react ✅ success
vite-plugin-react-pages ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ❌ failure
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ❌ failure

@patak-dev patak-dev merged commit 5778365 into main Aug 30, 2023
10 of 11 checks passed
@patak-dev patak-dev deleted the revert-14024 branch August 30, 2023 11:53
@frank-weindel
Copy link

The TypeScript files for LightningCSS are causing TypeScript errors when building vite:

> tsc --emitDeclarationOnly --outDir temp/node -p src/node

../../node_modules/.pnpm/lightningcss@1.21.7/node_modules/lightningcss/node/index.d.ts:27:13 - error TS2749: 'Features' refers to a value, but is being used as a type here. Did you mean 'typeof Features'?

27   include?: Features,
               ~~~~~~~~

../../node_modules/.pnpm/lightningcss@1.21.7/node_modules/lightningcss/node/index.d.ts:29:13 - error TS2749: 'Features' refers to a value, but is being used as a type here. Did you mean 'typeof Features'?

29   exclude?: Features,
               ~~~~~~~~

src/types/lightningcss.d.ts:16:13 - error TS2749: 'Features' refers to a value, but is being used as a type here. Did you mean 'typeof Features'?

16   include?: Features
               ~~~~~~~~

src/types/lightningcss.d.ts:17:13 - error TS2749: 'Features' refers to a value, but is being used as a type here. Did you mean 'typeof Features'?

17   exclude?: Features

@ArnaudBarre
Copy link
Member Author

Fixed on main: parcel-bundler/lightningcss#570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants