Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): add testcase for cli usage in a package with type: module #5216

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

dominikg
Copy link
Contributor

@dominikg dominikg commented Oct 7, 2021

Description

tests usage of cli in a package with "type":"module" in it's package.json.
This test covers reading vite.config.js with dynamic import, which is not covered by the regular cli testsuite.
see #5213

Additional context

The majority of this test is copy-paste of packages/playground/cli which isn't ideal, but editing these files on the fly would have been more complex.

I did verify that an error thrown from dynamicImport introduced in #5213 does fail in this testsuite.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 242fa35 into vitejs:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants