Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: server fs strict by default #5341

Merged
merged 4 commits into from
Oct 27, 2021
Merged

feat!: server fs strict by default #5341

merged 4 commits into from
Oct 27, 2021

Conversation

patak-dev
Copy link
Member

Description

Enable server.fs.strict by default and graduate it from experimental. SvelteKit has been using this by default without issues for a few minors.

Suggested target: 2.7

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev requested a review from antfu October 18, 2021 19:42
@patak-dev patak-dev added this to the 2.7 milestone Oct 18, 2021
@patak-dev patak-dev added the p4-important Violate documented behavior or significantly improves performance (priority) label Oct 18, 2021
benmccann
benmccann previously approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to enable this by default. Just FYI, there's a bug making it not fully take effect: #5345

packages/vite/src/node/server/index.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes Oct 19, 2021
View reviewed changes
@patak-dev patak-dev dismissed stale reviews from Shinigami92 and benmccann via 6299fd5 October 19, 2021 12:47
@antfu antfu mentioned this pull request Oct 21, 2021
Merged
9 tasks
@patak-dev
Copy link
Member Author

Removed the warning message about strict going to be enable later in the latest commit

@patak-dev patak-dev merged commit 2136771 into main Oct 27, 2021
@patak-dev patak-dev deleted the feat/fs-strict-by-default branch October 27, 2021 20:20
@Artur- Artur- mentioned this pull request Nov 16, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@benmccann benmccann benmccann left review comments

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@patak-dev @benmccann @Shinigami92