Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: clarify flag documentation for --db_charset #16422

Closed
mcrauwel opened this issue Jul 17, 2024 · 0 comments · Fixed by #16423
Closed

Feature Request: clarify flag documentation for --db_charset #16422

mcrauwel opened this issue Jul 17, 2024 · 0 comments · Fixed by #16423

Comments

@mcrauwel
Copy link
Contributor

mcrauwel commented Jul 17, 2024

Feature Description

the --db_charset flag is currently documented as follows:

--db_charset string                                                Character set used for this tablet. (default "utf8mb4")

While this flag allows for a collation to be configured as well.
Suggestion to change the description as follows:

Character/Collation set used for this tablet, make sure this charset/collation is supported by the lowest MySQL version in the cluster. (default "utf8mb4")

Use Case(s)

In the process of migrating from MySQL 5.7 to 8.0.

utf8mb4 has a different default collation in both 5.7 and 8.0 specifying the 5.7 default collation utf8mb4_general_ci in this flag will allow there replication from 8.0 back to 5.7 to work

if we don't specify a collation supported by the lowest of MySQL versions, replication will break.

@mcrauwel mcrauwel added Needs Triage This issue needs to be correctly labelled and triaged Type: Feature labels Jul 17, 2024
@shlomi-noach shlomi-noach added Type: Documentation Component: Documentation docs related issues/PRs and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants