Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap.sh should fail fast if go is not installed #360

Closed
rushiagr opened this issue Jan 28, 2015 · 2 comments
Closed

bootstrap.sh should fail fast if go is not installed #360

rushiagr opened this issue Jan 28, 2015 · 2 comments

Comments

@rushiagr
Copy link
Contributor

Even if go is not installed (or is not on the $PATH, which is more likelier), the script goes on and executes completely. Two solutions: 1. Check if go is present, and fail if not. 2. Pass -e flag to the bash script (set -e), which will make the script fail as soon as first error is encountered (but we might not want this)

@enisoc
Copy link
Member

enisoc commented Jan 28, 2015

We should probably run with 'set -e' but we'd need to clean up bootstrap.sh and dev.env first. I think there are places where we're ok with things failing, so we'd need to fix those so they don't derail everything.

@rushiagr
Copy link
Contributor Author

Yes, that's the problem with using 'set -e'. I have submitted a pull request #361 which fails if go is not present

@enisoc enisoc closed this as completed Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants