Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[concurrency] Add guard against potentially blocking forever in ErrorGroup.Wait() when NumGoroutines is 0 #7463

Merged
merged 1 commit into from Feb 8, 2021
Merged

[concurrency] Add guard against potentially blocking forever in ErrorGroup.Wait() when NumGoroutines is 0 #7463

merged 1 commit into from Feb 8, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Feb 7, 2021 •
edited by askdba

Closes #7462

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

Related Issue(s)

Checklist

  • Should this PR be backported? No (error group is in master but not any release branches)
  • Tests were added or are not required
  • Documentation was added or is not required N/A

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@ajm188
Add guard against potentially blocking forever when NumGoroutines is 0
d1e07fc 
Closes vitessio#7462

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from deepthi February 7, 2021 17:10
@ajm188 ajm188 requested a review from sougou as a code owner February 7, 2021 17:10
@ajm188 ajm188 changed the title Add guard against potentially blocking forever when NumGoroutines is 0 [concurrency] Add guard against potentially blocking forever in ErrorGroup.Wait() when NumGoroutines is 0 Feb 7, 2021
@ajm188 ajm188 mentioned this pull request Feb 7, 2021
Merged
8 tasks
@deepthi deepthi merged commit 39df6cd into vitessio:master Feb 8, 2021
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@ajm188 ajm188 deleted the am_error_group_zero branch March 4, 2021 16:32
@ajm188 ajm188 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
Component: Cluster management Type: Bug
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

[concurrency] ErrorGroup blocks forever when Wait is called with NumGoroutines = 0
3 participants
@ajm188 @deepthi @askdba