vitest fails when using node v18.17.0 - TypeError: The "path" argument must be of type string or an instance of Buffer or URL. Received an instance of URL

[sandrosc]

Describe the bug

 FAIL  test/App.test.tsx [ test/App.test.tsx ]
TypeError: The "path" argument must be of type string or an instance of Buffer or URL. Received an instance of URL
 ❯ Object.openSync node:fs:595:10
 ❯ readFileSync node:fs:471:35
 ❯ node_modules/vitest/node_modules/vite/dist/node/constants.js:5:32

Serialized Error: {
  "code": "ERR_INVALID_ARG_TYPE",
}

 Test Files  1 failed (1)
      Tests  no tests
   Start at  16:23:56
   Duration  1.23s (transform 28ms, setup 0ms, collect 0ms, tests 0ms, environment 620ms, prepare 119ms)

Apparently node v18.17.0 comes with a new URL parser, which might explain why the check if the path argument is an URL fails. This might also be a node issue. We fixed it by upgrading to node v20, but downgrading should also work.

Reproduction

Run vitest with a test on node v18.17.0.

System Info

This issue first occurred in a github action workflow:
- ubuntu-latest github image
- actions/setup-node@v3 with node-version 18

Used Package Manager

yarn

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[AriPerkkio]

This can be reproduced on Vitest's test cases: test/web-worker. Tests fail constantly:

 DEV  v0.33.0 /x/vitest/test/web-worker

 ❯ test/clone.test.ts (0)
 ❯ test/sharedWorker.spec.ts (0)
 ❯ test/postMessage.test.ts (0)
 ❯ test/init.test.ts (0)

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 4 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/clone.test.ts [ test/clone.test.ts ]
 FAIL  test/init.test.ts [ test/init.test.ts ]
 FAIL  test/postMessage.test.ts [ test/postMessage.test.ts ]
 FAIL  test/sharedWorker.spec.ts [ test/sharedWorker.spec.ts ]
TypeError: The "path" argument must be of type string or an instance of Buffer or URL. Received an instance of URL
 ❯ Object.openSync node:fs:595:10
 ❯ readFileSync node:fs:471:35
 ❯ ../../node_modules/.pnpm/vite@4.3.9_@types+node@18.7.13/node_modules/vite/dist/node/constants.js:5:32

This error is coming up randomly on CI too.

Is this a NodeJS bug? The error message makes no sense:

TypeError: The "path" argument must be of type string or an instance of Buffer or URL. Received an instance of URL

[AriPerkkio]

This only fails on jsdom. The URL instance passed to readFileSync makes Node throw an error now. Vitest test environments node and happy-dom work fine.

[sheremet-va]

It probably doesn't work because URL in jsdom is replaced with a custom implementation.