Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inherit concurrent/sequential in nested suites #4482

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix: inherit concurrent/sequential in nested suites #4482

merged 2 commits into from
Nov 15, 2023

Conversation

dsyddall
Copy link
Contributor

Description

Fixes #4480

Currently, describe.sequential has no effect as describe does not correctly inherit the concurrent option from the parent suite (reproduction). This PR fixes the inheritance of concurrent/sequential options so that tests within describe nested within describe.concurrent run concurrently.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 12, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 56779cf
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6550566d41d94f0008ddabef
😎 Deploy Preview https://deploy-preview-4482--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit ca168a1 into vitest-dev:main Nov 15, 2023
14 of 16 checks passed
@dsyddall dsyddall deleted the fix-ensure-concurrent-sequential-inherited branch November 15, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested suites run tests serially inside a concurrent suite
2 participants