Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): remove sequencer usage from createVmThreadsPool function (fix #4637) #4638

Merged
merged 2 commits into from
Dec 2, 2023
Merged

fix(vm): remove sequencer usage from createVmThreadsPool function (fix #4637) #4638

merged 2 commits into from
Dec 2, 2023

Conversation

mhogeveen
Copy link
Contributor

Description

--pool=vmThread in combination with --shard=1/x skips test files. This is due to unnecessary code remaining in the createVmThreadsPool function after a refactor where the Sequencer was refactored to be outside of pools.

This PR removes that code.

Related issue: #4637

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 90e6f37
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/656a2f8e43ec2900081719e9

@sheremet-va
Copy link
Member

Please, don't format code with your formatter

@mhogeveen
Copy link
Contributor Author

My bad on the formatting. I've returned it to it's original state

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding @mhogeveen!

@AriPerkkio AriPerkkio merged commit 54d52d4 into vitest-dev:main Dec 2, 2023
16 checks passed
@mhogeveen
Copy link
Contributor Author

mhogeveen commented Dec 2, 2023

Great finding @mhogeveen!

Thanks! Happy to help
Any idea when this fix will make it into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants