Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mainRun not functional due to startExeLine.trim #49

Open
Gcenx opened this issue Jan 4, 2020 · 0 comments
Open

mainRun not functional due to startExeLine.trim #49

Gcenx opened this issue Jan 4, 2020 · 0 comments

Comments

@Gcenx
Copy link
Collaborator

Gcenx commented Jan 4, 2020

NSMutableArray* flags = [[startExeLine.trim componentsSeparatedByString:@" "] mutableCopy];
[flags addObject:[wineStartInfo getWineRunFile]];

Currently this doesn't work as expected so for testing I'm doing the following;

            NSMutableArray* flags = [NSMutableArray array];
            //�TODO: Find a better way to handle this
            if ([wineStartInfo isRunWithStartExe])
            {
                startExeLine = @"start";
                [flags addObject:startExeLine];
            }
            [flags addObject:[wineStartInfo getWineRunFile]];
            [flags addObject:[wineStartInfo getProgramFlags]];

While doing the above does function, however if an executable has any spaces within its name it will fail to launch.

Edit;
Also launch flags don't work

Edit2:
I've edited the above it now launches executabled and uses flags correctly, if the executable contains spaces it still fails to launch

Edit3:
Edited the code again, now it works but seems the gecko issue might be caused by some other issue as some launches now cause programs to crash out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant