-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added hoverable list in feeds section #120
Conversation
please review @sebastian-code!! |
Thanks @chetanya-shrimali for the PR, please, change line 64 in |
Hi @chetanya-shrimali after some testing I found than the code has the following bugs:
Please fix it. |
Okk!! I'll fix it! But please tell me more about 2nd point. Also when i tried logging in with 2 different accounts. It gave me both the users who liked. Still i try to figure it out. Also do we have a gitter channel for bootcamp? |
To answer your question on the 2nd point, the functionality only works if the user has liked that feed post previously, if the user is still able to like the feed post, the functionality doesn't work. |
Sebastian-code I want to add admin feature in this website so I can supervise the content and feeds posted by users, but I'm getting an error and unable to do it in conventional way (setting admin in url and settings) what should I do?/ |
Hey, @sebastian-code I was recently working on the pr and how do you think we should solve the refresh in real-time issue. shall we use Knockout js? |
I personally dislike to add libraries when the project is only going to use it only once, and just for that small activity. Bootcamp relies a lot on AJAX calls to update this kind of information, isn't that enough? The other thing is than I'm planning to incorporate WebSockets (maybe with django-channels... someday... hopefully) which in turn deprecates AJAX and many other libraries, and I want to avoid unnecessary efforts to achieve this migration. |
Yaa, that's true @sebastian-code. AJAX would do the task. |
I'll use setInterval() function. |
solved the issue regarding 1 and 2 point addressed above. Updated the bootstrap, jquery scripts to latest version.
Hi @chetanya-shrimali this is great, now the problems 1 and 2 are solved, thanks for that; at this point only the third error persists. When you like a feed post, the list doesn't updates for none of the logged in users, and all of them need to reload the page to be able to see the list of users who liked that feed post. Additionally, If you unlike a feed post, the hoverable list will keep showing the logged in user who unliked the feed post, unless you reload the page. |
Yaa, @sebastian-code only problem that persists is the update in real-time. I was getting an error on AJAX calls regarding the url. |
Have you considered using a new AJAX view to answer that call? |
Please remember than that request is not related to this topic, being this a discussion about a PR to the project. What you are asking is related to support. To answer your question, that happens because when For more information I recommend to you to look into the documentation |
@sebastian-code can you please elaborate!! |
A single view that returns a JSON object just with the desired information to update the components of the DOM. |
Added list to feeds section showing list of likers on hover as addressed in issue #21