v3.6.1: Java 11, Embedding Improvements, Complete Reformatting #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s rather than only the most representative frame.
This is required since FFMpegAudioDecoder and TechnicalVideoMetadataExtractor use Math.floorDiv, which is a function only available since Java 9.
Due to popular demand.
lucaro
approved these changes
Jan 4, 2022
Spiess
approved these changes
Jan 4, 2022
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
Co-authored-by: Luca Rossetto <lucaro@lucaro.ch> Co-authored-by: Florian Spiess <florian.spiess@unibas.ch> Former-commit-id: 28fd3ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# Changes
I'd like to merge this PR before #224, because #224 targets master and I think it makes more sense to first merge the reformatting. I'll take care of making sure #224 is merged with this branch, since that might be quite some work due to the reformatting.