feat: Add read method in RefSkel
#1193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneGudermann
added
feature
phorward
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Hello @ArneGudermann, Thanks for facing this issue.
Can you first fix the provided suggestions?
Furthermore, I think it might be good to add a read-method generally to Skeleton, so that it can be used as a replacement for fromDB() - Why? Because issue #630 already proposes a Skeleton.read() method.
It should have the signature def read(self, key=None), and in the case that no key is provided, skel["key"] will be used (as it's the case here). If you want, I can make a follow-up pull request when this is merged.
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
sveneberth
requested changes
Jul 15, 2024
Co-authored-by: Sven Eberth <mail@sveneberth.de>
sveneberth
previously approved these changes
Jul 15, 2024
phorward
requested changes
Jul 15, 2024
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
phorward
reviewed
Jul 24, 2024
phorward
approved these changes
Jul 24, 2024
sveneberth
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1101