Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a RefSkel.read() shortcut to read entire target skeleton #1101

Closed
phorward opened this issue Mar 13, 2024 · 1 comment
Closed

Provide a RefSkel.read() shortcut to read entire target skeleton #1101

phorward opened this issue Mar 13, 2024 · 1 comment
Labels
feature New feature or request Priority: Low This issue can be considered with enough idle time.

Comments

@phorward
Copy link
Member

For several use-cases, this

studyworkflow_skel = conf.main_app.studyworkflow.viewSkel()

if not studyworkflow_skel.fromDB(skel["studyworkflow"]["dest"]["key"]):
    logging.error(f"""The studyworkflow {skel["studyworkflow"]["dest"]=} was meanwhile deleted?""")
    return

could be substituted by

studyworkflow_skel = skel["studyworkflow"]["dest"].read()

with nice exceptions being thrown when the skeleton is gone!

@phorward phorward added feature New feature or request Priority: Low This issue can be considered with enough idle time. labels Mar 13, 2024
@phorward phorward added this to the ViUR-core v3.7 milestone Mar 13, 2024
phorward added a commit that referenced this issue Jul 30, 2024
Resolves #1101

---------

Co-authored-by: Jan Max Meyer <jmm@phorward.de>
Co-authored-by: Sven Eberth <mail@sveneberth.de>
@phorward
Copy link
Member Author

phorward commented Oct 7, 2024

Fixed by #1193

@phorward phorward closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Priority: Low This issue can be considered with enough idle time.
Projects
None yet
Development

No branches or pull requests

1 participant