Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Distance Matrix API by postcode/place name #2

Closed
blundell89 opened this issue Apr 16, 2016 · 3 comments
Closed

Search Distance Matrix API by postcode/place name #2

blundell89 opened this issue Apr 16, 2016 · 3 comments
Assignees

Comments

@blundell89
Copy link

Hi,

We're looking to use the Distance Matrix API and come across your wrapper (which looks really useful, thanks!).

The DistanceMatrixRequest has the Origins and Destinations properties that both take an IEnumerable<Location>. The Location class currently has one constructor that takes a lat and long. Would it be possible to take a second constructor where we can pass an address string instead? The documentation indicates that this is an acceptable request.

If you're happy for the change to be implemented I could clone and PR it?

Thanks,

Lee & @Dingwall

@vivet
Copy link
Owner

vivet commented Apr 16, 2016

Hi

Feel free to make a PR and i will merge it.

On Sat, Apr 16, 2016 at 5:34 PM, Lee Blundell notifications@github.com
wrote:

Hi,

We're looking to use the Distance Matrix API and come across your wrapper
(which looks really useful, thanks!).

The DistanceMatrixRequest has the Origins and Destinations properties
that both take an IEnumerable. The Location class currently has
one constructor that takes a lat and long. Would it be possible to take a
second constructor where we can pass an address string instead? The
documentation indicates that this is an acceptable request.

If you're happy for the change to be implemented I could clone and PR it?

Thanks,

Lee & @Dingwall https://github.com/dingwall


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#2

MICHAEL VIVET
VP Product & Development

Mobile: +45 30 86 45 25
Email: mv@drivr.com
Address: Jagtvej 111, DK-2200 København N

_https://_drivr.com http://www.drivr.com/
_https://_facebook.com/drivrhq
https://twitter.com/drivr https://twitter.com/drivr

@vivet
Copy link
Owner

vivet commented Apr 18, 2016

I have merged and uploaded new nuget package

@blundell89
Copy link
Author

That's great, thanks! 😄

@vivet vivet self-assigned this May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants