Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n redesign #355

Merged
merged 45 commits into from
Feb 13, 2023
Merged

I18n redesign #355

merged 45 commits into from
Feb 13, 2023

Conversation

chenejac
Copy link
Contributor

@chenejac chenejac commented Dec 15, 2022

VIVO GitHub issue: i18n redesign project board

VIVO PR

What does this pull request do?

Moving UI labels from property files to rdfs
Removing language specific template files
Merging Vitro-language repository into Vitro repository
Support for institution specific translations (private language subtags)

What's new?

*.property UI label files are migrated to *.ttl files
i18n module is extended to support loading of UI labels from ttl files and property files
ftl files from Vitro-languages have been moved to Vitro repository (universal language constructions working for all languages has been used)
home artifacts and UI label files from Vitro-languages have been moved to Vitro
pom files have been adopted
*.yml files (build) have been adopted

How should this be tested?

  • instructions for testing are available in linked VIVO PR

Example:

  • Does this change require documentation to be updated? Yes, this wiki page will describe adding new UI language - https://wiki.lyrasis.org/display/VIVODOC114x/Internationalization
  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository? VIVO-languages repository is not needed any more, the PR also includes changes in the workflows (build GitHub action).
  • Could this change impact execution of existing code? No
  • Large pull requests should be avoided. If this PR is large (more than 1,000 lines of codes), please provide short explanation why your contribution can't be decoupled in smaller PRs. This is the result of two sprints

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

litvinovg and others added 30 commits October 6, 2022 15:33
[ i18n sprint ] Fixes for new individual form
[i18n sprint] Language-neutral help text in autocomplete forms
[ i18n sprint] remove terms of use controller
* Decouple email templates and translations

* provide siteName variable to error templates
* making generic searh-help by using translation properties' keys and i18n bean

* Adding new line at the end of the file

* Adding translation for title of an anchor
…rom fr_CA (#336)

* Apply fixes from french lib properties

* Apply fixes from fr_CA autoCompleteObjectPropForm

* fixed for fr_CA and other languages

* fixes from fr_CA

* fix for  autoCompleteObjectPropForm.ftl

* fixed wrong call for i18n bundle
* renamed I18nBundle

* added I18nBundle interface

* Added translation provider

* prototype of TranslationConverter

* convert all properties

* fixes

* added caching

* Removed obsolete code

* Improved logging

* fixed getting already existing label

* Fix to get RDF Service for configuration models

* fix translation request query

* added INTERFACE_I18N_FIRSTTIME_BACKUP model

* converter test added

* formatting fixes

* Translation provider tests added

* cleanups, added cache test for translation provider

* fix: get theme info from web app dao factory as sparql queries on both content and configuration models not supported
…itro

[i18n-3762] Moving UI labels translations into vitro
adding English as default language
chenejac and others added 5 commits December 13, 2022 11:37
…of toString() method with toLanguageTag() method, adding checks for locale.stripExtensions() where it was neccessary, adding information about private tag in the drop down selection of a UI language
[3800 i18n redesign] Supporting private tags
[3801 i18n] Renaming files, removing language suffixes for rdf files
chenejac and others added 3 commits December 16, 2022 10:16
… input strings for MethodFormat.format method
* Faux data properties

* Use not disjointed classes for faux properties domain and range options

* Fix faux object property shadowing real property
List faux data properties
List faux properties which base properties domain don't match current subject

* Write exception to log in VClassDaoJena

* filter faux properties returned in possiblePropInstForIndividual

* safety checks added

* extracted getBaseLabel method, fixed base labels for data properties

* fix for prev commit

* Formatting fixes

* More formatting fixes

* More formatting fixes

* More formatting fixes

* More formatting fixes

* More formatting fixes

Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
@chenejac chenejac requested review from a user and brianjlowe December 17, 2022 17:13
litvinovg and others added 7 commits December 22, 2022 13:49
support for combining parameters and apostrophe
Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
…ertyWrapper (#360)

Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
* fix, i18n: added link to instance in Russian translations

* fixed text style

* one more fix
Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
@chenejac chenejac merged commit 48c88d3 into main Feb 13, 2023
@chenejac chenejac deleted the i18n-redesign branch August 31, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants