Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow build speed with punica after #1804 #2571

Closed
zhuohan123 opened this issue Jan 24, 2024 · 3 comments
Closed

Slow build speed with punica after #1804 #2571

zhuohan123 opened this issue Jan 24, 2024 · 3 comments
Assignees

Comments

@zhuohan123
Copy link
Member

After #1804, the build speed of vLLM becomes significantly slower. Most of the time was spent on /home/zhuohan/vllm/vllm/csrc/punica/bgmv/bgmv_all.cu. Should we turn off punica by default?

cc @Yard1

@Yard1
Copy link
Collaborator

Yard1 commented Jan 24, 2024

Should we make it depend on an env var that can be set when calling setup.py/pip install?

@Yard1 Yard1 self-assigned this Jan 25, 2024
@njhill
Copy link
Member

njhill commented Jan 28, 2024

Duplicated by #2604 and now resolved by #2605?

@Yard1
Copy link
Collaborator

Yard1 commented Jan 29, 2024

Yes!

@Yard1 Yard1 closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants