Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customisable ConfigReader instances for Java time #52

Closed
vlovgr opened this issue Oct 12, 2017 · 1 comment
Closed

Customisable ConfigReader instances for Java time #52

vlovgr opened this issue Oct 12, 2017 · 1 comment

Comments

@vlovgr
Copy link
Owner

vlovgr commented Oct 12, 2017

Ciris currently has ConfigReader instances for many java.time types in the core library (see JavaTimeConfigReaders). Some of these types support parsing with different formats, rather than the default one used by the current instances. The idea is to add configurable java.time instances, where the user supplies the format (DateTimeFormatter) and we create a ConfigReader for the requested type.

For inspiration, PureConfig has done something similar, as seen here:
https://github.com/pureconfig/pureconfig/blob/master/core/src/main/scala/pureconfig/configurable/package.scala

@fmsbeekmans
Copy link

Started working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants