Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jasmine-node exits with no output on a bad URL #33

Closed
andyshinn opened this issue Jul 12, 2013 · 3 comments
Closed

jasmine-node exits with no output on a bad URL #33

andyshinn opened this issue Jul 12, 2013 · 3 comments

Comments

@andyshinn
Copy link

We ran into an issue when writing some tests where jasmine-node was actually just exiting with 0 even though nothing was happening! It turns out, one of the URLs in our frisby test was bad. Here is an example:

var frisby = require('frisby');

frisby.create('We should be able to GET a URL')
  .get('https://googlenotreally.com')
  .expectStatus(200)
  .toss();

When run with jasmine-node --verbose, this silently exits with 0. The working URL outputs the test and passes normally:

var frisby = require('frisby');

frisby.create('We should be able to GET a URL')
  .get('https://google.com')
  .expectStatus(200)
  .toss();

I'm running with frisby@0.6.8 and jasmine-node@1.10.2.

Surely, the test with the bad URL should fail instead of exit cleanly. Any ideas what might be happening?

@andyshinn
Copy link
Author

I notice that it fails in method this.current.it with the following error:

[Error: Destination URL may be down or URL is invalid.
Trying: 'GET https://googlenotreally.com'
Got: 'Error: getaddrinfo ENOTFOUND'
]

@vlucas
Copy link
Owner

vlucas commented Jul 15, 2013

Interesting. I know it's throwing that Exception, because I fixed it at some point, but it looks like it's getting trapped somewhere else. I'll investigate this further.

@vlucas
Copy link
Owner

vlucas commented Jul 26, 2017

This has been fixed in v2. Please update.

@vlucas vlucas closed this as completed Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants