Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation seems fairly out of date #67

Closed
dacarley opened this issue Jan 30, 2014 · 5 comments
Closed

Documentation seems fairly out of date #67

dacarley opened this issue Jan 30, 2014 · 5 comments

Comments

@dacarley
Copy link

Here are the issues I've noticed:

Missing documentation:
The '&' syntax for paths
.globalSetup()
Would be good to list out what can be configured here.
.timeout()
.reset()
.not()
.addHeader()
.addHeaders()
.removeHeader()
.responseType()
Actually, this appears to be pointless. The value of
.auth()
all of the request methods, such as .get() and .post()
.expectHeaderToMatch()
.expectJSONSchema()
format of the 'length' parameter to .expectJSONLength()
.inspectRequest()
.inspectResponse()
.inspectHeaders()
.inspectStatus()
.retry()
.waits()
.after()
.afterJSON()
.exceptionHandler()
.setResponseJSON()
.setResponseBody()
.setResponseHeaders()
.setResponseHeader()
the 'retry' param to toss()

All of the frisby matchers
toMatchOrBeNull
toMatchOrBeEmpty
toBeType
toBeTypeOrNull
toContainJson
toContainJsonTypes

Also, the documentation in README.MD should match up with the documentation on the frisbyjs.com website.

Additionally, it'd be great if a variety of example scripts were provided to demonstrate the power of Frisby.

I can take a crack at documenting some of this. A pull request makes sense for the README.MD and any examples, but what about for the website content?

@vlucas
Copy link
Owner

vlucas commented Jan 30, 2014

I would absolutely accept a PR to update the documentation and README. As for the website, I plan on moving it to a static website with markdown files, probably using something like middleman.

@kreutter
Copy link
Contributor

kreutter commented Apr 3, 2014

I'd also like to offer some help on updating the website if possible. There is at least one example up there that doesn't work (fails) and the twitter examples are no longer working since they are using the no longer available older api.

@marcin-wosinek
Copy link
Collaborator

@vlucas how about moving documentation to github pages?

@vlucas
Copy link
Owner

vlucas commented Jun 10, 2014

I did - I just apparently never updated this ticket: https://github.com/vlucas/frisby-site

I ended up going with hexo, which is a node.js static site generator.

@cpanato
Copy link

cpanato commented Dec 18, 2014

@vlucas will try to update some docs in the frisby-site and make a PR

@vlucas vlucas closed this as completed Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants