Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globalSetup example out of date #9

Closed
terkhorn opened this issue Sep 6, 2012 · 2 comments
Closed

globalSetup example out of date #9

terkhorn opened this issue Sep 6, 2012 · 2 comments

Comments

@terkhorn
Copy link

terkhorn commented Sep 6, 2012

Hi vlucas,

First off, thanks for contributing this node module. I've found it pretty darned helpful and quick to get up and running with!

I believe that the example in your README.md is out of date. To wit:

frisby.create('GET user johndoe')
  .globalSetup({ // globalSetup is for ALL requests
    request: {
      headers: { 'X-Auth-Token': 'fa8426a0-8eaf-4d22-8e13-7c1b16a9370c' }
    }
  })
  .get(URL + '/users/3.json')

...should be...

frisby.globalSetup({ // globalSetup is for ALL requests
    request: {
      headers: { 'X-Auth-Token': 'fa8426a0-8eaf-4d22-8e13-7c1b16a9370c' }
    }
  });

frisby.create(...)

Cheers,
Felix

@vlucas vlucas closed this as completed in a8b4538 Sep 6, 2012
@vlucas
Copy link
Owner

vlucas commented Sep 6, 2012

Thanks for noticing this and taking time to submit an issue! :)

@terkhorn
Copy link
Author

Super awesome, thanks vlucas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants