generate.py: don't skip files with mtime = 0 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR: 'generate.py' fails to generate tests on file with mtime=0: ``` $ touch --date=@0 clar.{c,h} $ python generate.py Traceback (most recent call last): File "generate.py", line 242, in <module> if suite.write(): File "generate.py", line 211, in write data.write(t.render()) File "generate.py", line 25, in render out = "\n".join("extern %s;" % cb['declaration'] for cb in self.module.callbacks) + "\n" AttributeError: 'Module' object has no attribute 'callbacks' ``` Long story: Error happens because 'generate.py' uses '0' as a sentinel value. In order to enhance reproducibility of builds some build systems timestamps to a stable date (say, release tarball date). https://www.gnu.org/software/guix/ goes even farther that that and sets mtime to '0'. Unfortunately it is exactly the same as sentinel value in 'generate.py'. That causes 'generate.py' to treat all test files as "already read". The change changes value to 'None'. Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
mbakke
pushed a commit
to guix-mirror/guix
that referenced
this pull request
Jun 3, 2017
This commit reverts 'patch' hack introduced in a48a107 and fixes bug in the Clar test framework. Patch is proposed to Clar upstream as <clar-test/clar#78>. * gnu/local.mk: Add libgit2-0.25.1-mtime-0.patch. * gnu/packages/patches/libgit2-0.25.1-mtime-0.patch: New file. * gnu/packages/version-control.scm (libgit2)[arguments]: Remove 'apply-patch' phase. [inputs]: Remove "patch". [source]: Add 'patches' field. Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru> Signed-off-by: Ludovic Courtès <ludo@gnu.org>
|
Now that's a corner case! :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
'generate.py' fails to generate tests on file with mtime=0:
Long story:
Error happens because 'generate.py' uses '0' as a sentinel value.
In order to enhance reproducibility of builds some build systems
timestamps to a stable date (say, release tarball date).
https://www.gnu.org/software/guix/ goes even farther that that
and sets mtime to '0'. Unfortunately it is exactly the same as
sentinel value in 'generate.py'. That causes 'generate.py' to
treat all test files as "already read".
The change changes value to 'None'.
Signed-off-by: Sergei Trofimovich slyfox@gentoo.org