Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add utm_source and utm_medium #30

Closed
yogodoshi opened this issue Mar 3, 2013 · 1 comment
Closed

Automatically add utm_source and utm_medium #30

yogodoshi opened this issue Mar 3, 2013 · 1 comment

Comments

@yogodoshi
Copy link

Hi Vicent, I love Rinku but I need a feature that it doesnt have yet: I wanted to automatically add utm_source and utm_medium parameters in some cases.

I have a social network and wanted that when a user posts links on comments and messages, Rinku automatically added those parameters to the URLs so when I bring visits to another site, they easily know where those visitors came from.

Should I make a pull request or fork it and do my own version with this feature?

@vmg
Copy link
Owner

vmg commented Mar 3, 2013

Hey! Thanks for the kind words! Unfortunately, we use Rinku in production here in GitHub and I cannot really merge a feature that add extra parameters to all URLs to the library. It goes against our design principles and the goal of the library.

You'll have to implement that on your own fork. Don't hesitate to ask if you need advice on how to do it, though. :)

Thanks!

@vmg vmg closed this as completed Mar 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants