Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby support #75

Open
headius opened this issue Feb 23, 2018 · 4 comments
Open

JRuby support #75

headius opened this issue Feb 23, 2018 · 4 comments

Comments

@headius
Copy link

headius commented Feb 23, 2018

Would you be opposed to including equivalent extension code for JRuby? The port should be pretty straightforward: I have done similar for other small extensions like Psych and the code can be nearly a 1:1 match.

rinku is a direct dependency of Discourse, which we would like to support on JRuby.

@kivikakk
Copy link
Contributor

I would absolutely not be opposed, this would be a delightful addition.

One thing I should mention is that I lack experience with JRuby itself, so I might need to delegate maintenance (if any — this library is pretty stable) to the community.

If this is fine with you, then by all means!

@headius
Copy link
Author

headius commented Feb 26, 2018

That seems reasonable to me. I will start a port on a fork and we'll see if we can bang this out!

@headius
Copy link
Author

headius commented Feb 26, 2018

I started doing a port, but then realized it may be easier to wrap an existing library and just make it match rinku's API. So I started that process here: robinst/autolink-java#20

The autolink-java library says in its README that it is "inspired by rinku" so I'm hoping the mapping will be pretty close.

@kivikakk
Copy link
Contributor

👍 Neat! Let me know how that goes/if I can give any more assistance on this side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants