fix(tokens): fix generating typography aliases #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
williamernest
force-pushed
the
wernest/fix_alias_typography
branch
from
738fd3f
to
026201e
Compare
williamernest
commented
Aug 28, 2023
williamernest
force-pushed
the
wernest/fix_alias_typography
branch
4 times, most recently
from
daa5ab8
to
023dd98
Compare
williamernest
force-pushed
the
wernest/fix_alias_typography
branch
from
023dd98
to
21b4eed
Compare
kevinbuhmann
approved these changes
Aug 28, 2023
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token build process depends on the Token instance to generate the tokens correctly, and deepClone does not copy symbols, so the output was incorrect (aliases were being mapped to
var(--cds-);).This also adds the missing typography color changes to the themes.
Removes lodash deepClone.