Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add css custom properties #279

Conversation

yuhsianw
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #278

What is the new behavior?

--box-shadow, --icon-visibility, and --icon-margin CSS custom properties added to cds-accordion-header.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

github-actions bot commented Nov 16, 2023

👋 @yuhsianw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@yuhsianw yuhsianw marked this pull request as ready for review November 16, 2023 22:13
Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment regarding initializing the new values and adding a comment above the :root block to elaborate on why these fields are present.

@yuhsianw yuhsianw force-pushed the frankwang/accordion-add-css-properties branch from ca6c814 to b02d26e Compare November 17, 2023 19:44
@yuhsianw yuhsianw force-pushed the frankwang/accordion-add-css-properties branch from b02d26e to bbbff93 Compare November 17, 2023 19:57
@williamernest williamernest merged commit a38063c into vmware-clarity:main Nov 17, 2023
1 check passed
@yuhsianw yuhsianw deleted the frankwang/accordion-add-css-properties branch November 20, 2023 14:58
Copy link

🎉 This PR is included in version 6.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Dec 5, 2023

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants