Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typography): body, title, subsection and message tokens #283

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Dec 8, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

  • Body typography token line height is equal to 19.99 px.
  • Body typography token letter spacing is equal to -0.2 px.
  • Title typography token line height is equal to 28 px.
  • Title typography token letter spacing is equal to -0.199992 px.
  • Subsection typography token line height is equal to 20 px.
  • Message typography token line height is equal to 20 px.

Issue Number: N/A

What is the new behavior?

  • Body typography token line height is equal to 20 px.
  • Body typography token letter spacing is equal to -0.1 px.
  • Title typography token line height is equal to 32 px.
  • Title typography token letter spacing is equal to -0.2 px.
  • Subsection typography token line height is equal to 24 px.
  • Message typography token line height is equal to 24 px.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

github-actions bot commented Dec 8, 2023

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov valentin-mladenov changed the title fix(typography): increase body line height fix(typography): body token line height and letter spacing Dec 11, 2023
@valentin-mladenov valentin-mladenov changed the title fix(typography): body token line height and letter spacing fix(typography): body, section, subsection and message tokens Dec 11, 2023
@valentin-mladenov valentin-mladenov changed the title fix(typography): body, section, subsection and message tokens fix(typography): body, title, subsection and message tokens Dec 11, 2023
@valentin-mladenov valentin-mladenov merged commit 6917f3d into main Dec 12, 2023
1 check passed
Copy link

🎉 This PR is included in version 6.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
@valentin-mladenov valentin-mladenov deleted the fix-line-height-Body-14-RG-STD branch June 12, 2024 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants