Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button-action): show keyboard focus indicator #290

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

dtsanevmw
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

There is no focus indicator inside input groups when navigation through button actions.

Issue Number: CDE-1551

What is the new behavior?

Visible focus indicator.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

github-actions bot commented Jan 19, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw assigned AmyLiNow and unassigned AmyLiNow Jan 19, 2024
@dtsanevmw dtsanevmw marked this pull request as draft January 19, 2024 12:05
@dtsanevmw dtsanevmw marked this pull request as ready for review January 19, 2024 14:44
@dtsanevmw dtsanevmw merged commit 16c46dc into main Jan 22, 2024
1 check passed
@kevinbuhmann kevinbuhmann deleted the dtsanevmw/cde-1551 branch January 22, 2024 17:40
Copy link

🎉 This PR is included in version 6.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants