New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClrControlContainer component use wrong icon color #305
Comments
CAn you please provide a stackblitz so we can see the visual discrepancies |
The ClrControlContainer had wrong color on error icon as it sets the icon status to danger. This overrides the forms invalid color set by the form css. Other form containers such as ClrInputContainer don't set it either for this reason. Close: vmware-clarity#305 Signed-off-by: Ron Birk <rbirk@vmware.com>
That's not overriding the color of the icon. That's just setting the |
The `status="danger"` attribute sets the icon color and fill to red 700, but the form invalid color in ng-clarity is different. I think it's best to keep the `status="danger"` attribute for semantics and simply set the color and fill on the validation icons. closes #305
The `status="danger"` attribute sets the icon color and fill to red 700, but the form invalid color in ng-clarity is different. I think it's best to keep the `status="danger"` attribute for semantics/intention simply set the color and fill on the validation icons to the form invalid color. closes #305
The icon `status` attribute sets the icon color and fill which could result in slightly different colors being used for the validation icon and text. I think it's best to keep the icon `status` attributes for semantics/intention simply set the color and fill on the validation icons to the correct form color. closes #305
The icon `status` attribute sets the icon color and fill which could result in slightly different colors being used for the validation icon and text. I think it's best to keep the icon `status` attributes for semantics/intention simply set the color and fill on the validation icons to the correct form color. closes #305
The icon `status` attribute sets the icon color and fill which could result in slightly different colors being used for the validation icon and text. I think it's best to keep the icon `status` attributes for semantics/intention simply set the color and fill on the validation icons to the correct form color. closes #305 This is a backport of 28bbc62.
The icon `status` attribute sets the icon color and fill which could result in slightly different colors being used for the validation icon and text. I think it's best to keep the icon `status` attributes for semantics/intention simply set the color and fill on the validation icons to the correct form color. closes #305 This is a backport of 28bbc62.
🎉 This issue has been resolved in version 13.8.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 12.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
This is a bug report for the
@clr
Angular or UI versions of the design system.For the web-component implementation of Clarity (
@cds
), visit vmware-clarity/core.Describe the bug
ClrControlContainer component use wrong icon color. This is because it sets the icon status to "danger" which overrides the css for forms invalid color. Other container components don't set the status and why they work and use correct red color.
How to reproduce
Use the clr-control-container component as described here:
https://clarity.design/documentation/forms#:~:text=Custom%20and%20non%2DClarity%20Controls
Expected behavior
Error icon should have the same red color as the form invalid red, i.e. same red as the input control underline red.
Versions
Clarity version:
Framework:
Framework version:
Angular 13
Additional notes
Here is part of the source code of it. As you can see it adds the status. That line should be removed. See the clr-input-container as example as that one works.
The text was updated successfully, but these errors were encountered: