fix: ensure validation icons are the correct color #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
changed the title
ashleyryan
approved these changes
Sep 13, 2022
kevinbuhmann
force-pushed
the
kevin/validate-icon-color
branch
from
58f3deb
to
2708843
Compare
13 tasks
The icon `status` attribute sets the icon color and fill which could result in slightly different colors being used for the validation icon and text. I think it's best to keep the icon `status` attributes for semantics/intention simply set the color and fill on the validation icons to the correct form color. closes #305
kevinbuhmann
force-pushed
the
kevin/validate-icon-color
branch
from
2708843
to
3369ff0
Compare
kevinbuhmann
changed the title
kevinbuhmann
force-pushed
the
kevin/validate-icon-color
branch
from
3369ff0
to
bc918e4
Compare
1 task
|
🎉 This PR is included in version 13.8.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #305
supersedes #308
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Bugfix
What is the current behavior?
Issue Number: #305
What is the new behavior?
The validation icon and text are the same color.
Does this PR introduce a breaking change?
No.