fix(form): correct color on error icon #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ClrControlContainer had wrong color on error icon as it sets the icon status to danger. This overrides the forms invalid color set by the form css. Other form containers such as ClrInputContainer don't set it either for this reason. Close: vmware-clarity#305 Signed-off-by: Ron Birk <rbirk@vmware.com>
|
👋 @rbirkgit,
Thank you, 🤖 Clarity Release Bot |
13 tasks
kevinbuhmann
previously approved these changes
Sep 6, 2022
kevinbuhmann
reviewed
Sep 6, 2022
There was a problem hiding this comment.
I think clr-input-container might be wrong... If you search for class="clr-validate-icon" in the code, you will find other containers (checkbox, combobox, etc) that all set the status on icon. Should the status be removed from all of the icons? Or is there just a bug in the CSS?
1 task
|
I think this PR should be closed in favor of #311. |
1 task
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClrControlContainer had wrong color on error icon as it sets the icon status to danger. This overrides the forms invalid color set by the form css. Other form containers such as ClrInputContainer don't set it either for this reason.
Close: #305
Signed-off-by: Ron Birk rbirk@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 305
What is the new behavior?
Does this PR introduce a breaking change?
Other information