Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Proxy Settings stop installation #824

Closed
jrsmile opened this issue Mar 28, 2022 · 4 comments · Fixed by #840
Closed

[BUG] Proxy Settings stop installation #824

jrsmile opened this issue Mar 28, 2022 · 4 comments · Fixed by #840
Labels
bug Something isn't working
Milestone

Comments

@jrsmile
Copy link

jrsmile commented Mar 28, 2022

Describe the bug
When setting the proxy during ovf install the description of the proxy setting states it can be set with Quotes.
Unfortunately the installscript does not like this.
If you configure the Proxy like this : "http://proxy:port/"
the deployment script hangs and veba is not beeing installed.
this is because the Quotes close some variabe name in the installscript and you get a error.

To Reproduce
Steps to reproduce the behavior:
1.deploy the ovf
2. In the Wizzard set a Proxy Server according to description.
3. Finish deployment wizard
4. Turn on VM and have a look at the console.

Expected behavior
The proxy is set corectly and kubernetes is beeing deployed.

Version:

  • VEBA Form Factor: Appliance
  • VEBA Version: 0.7.2

Additional context
There should be a check to accept both versions with and without quotes
to clean the input before usage as variable in the script.

@jrsmile jrsmile added the bug Something isn't working label Mar 28, 2022
@github-actions
Copy link

Howdy 🖐   jrsmile ! Thank you for your interest in this project. We value your feedback and will respond soon.

@embano1 embano1 added this to the v0.7.3 milestone Mar 29, 2022
@dsbibby
Copy link
Contributor

dsbibby commented Mar 30, 2022

@lamw @embano1 - Happy to take a look at this if you like? I think it can be resolved by:

  • Changing the description in the appliance deployment to remove the quotes from the example
  • Adding some sanitization (i.e. trimming quotes and whitespace?) from the getOvfProperty.py script

@embano1
Copy link
Collaborator

embano1 commented Mar 30, 2022

@lamw @embano1 - Happy to take a look at this if you like? I think it can be resolved by:

  • Changing the description in the appliance deployment to remove the quotes from the example

  • Adding some sanitization (i.e. trimming quotes and whitespace?) from the getOvfProperty.py script

Go for it 👍🤦🏻‍♂️

Btw: do you think you can get some basic unit tests in too?

@dsbibby
Copy link
Contributor

dsbibby commented Mar 30, 2022

Yep, I was thinking that. Will sort something 🙂

dsbibby added a commit to dsbibby/vcenter-event-broker-appliance that referenced this issue May 13, 2022
Closes: vmware-samples#824

Signed-off-by: David Bibby <davidsbibby@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants