-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Proxy Settings stop installation #824
Comments
Howdy 🖐 jrsmile ! Thank you for your interest in this project. We value your feedback and will respond soon. |
Go for it 👍🤦🏻♂️ Btw: do you think you can get some basic unit tests in too? |
Yep, I was thinking that. Will sort something 🙂 |
Closes: vmware-samples#824 Signed-off-by: David Bibby <davidsbibby@gmail.com>
Describe the bug
When setting the proxy during ovf install the description of the proxy setting states it can be set with Quotes.
Unfortunately the installscript does not like this.
If you configure the Proxy like this : "http://proxy:port/"
the deployment script hangs and veba is not beeing installed.
this is because the Quotes close some variabe name in the installscript and you get a error.
To Reproduce
Steps to reproduce the behavior:
1.deploy the ovf
2. In the Wizzard set a Proxy Server according to description.
3. Finish deployment wizard
4. Turn on VM and have a look at the console.
Expected behavior
The proxy is set corectly and kubernetes is beeing deployed.
Version:
Additional context
There should be a check to accept both versions with and without quotes
to clean the input before usage as variable in the script.
The text was updated successfully, but these errors were encountered: