-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document FORCE_COLOR environment variable #581
Conversation
@gberche-orange, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
@gberche-orange thanks for adding this in. would you mind moving into kapp directory instead of kapp-controller. |
I think having the kctrl example in kapp-controller directory makes sense. We could probably have a kapp example added as well (to the kapp directory) ? |
thanks @cppforlife and @praveenrewar I've added two commits to also document FORCE_COLOR in the kapp documentation, and refined a bit the kctrl example command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gberche-orange Can you please sign the cla (if not already done).
@gberche-orange, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed. |
@gberche-orange, VMware has approved your signed contributor license agreement. |
Closes partially carvel-dev/kapp#632