Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for Pinniped Supervisor/JWTAuthenticator end-to-end flow #263

Closed
ankeesler opened this issue Dec 8, 2020 · 1 comment

Comments

@ankeesler
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We don't currently have an integration test that tests the end-to-end flow of 1) obtaining a token set from the Pinniped Supervisor and 2) using that token set to authenticate to a cluster via a JWTAuthenticator. We should add this as an integration test, since it is quite possible the most common Pinniped architecture that folks will deploy.

Describe the solution you'd like

We should have an integration test that 1) logs into the Pinniped Supervisor and gets a token set issued for a particular cluster and 2) uses that token set to authenticate to the particular cluster via a JWTAuthenticator.

Describe alternatives you've considered

None.

Are you considering submitting a PR for this feature?

  • How will this project improvement be tested?
    It is a test, so N/A.
  • How does this change the current architecture?
    It is a test, so N/A.
  • How will this change be backwards compatible?
    It is a test, so N/A.
  • How will this feature be documented?
    It is a test, so N/A.

Additional context

This came up during development of #258. We punted on this to try to optimize for the shortest path to a working system.

@ankeesler ankeesler changed the title Add integration test Add integration test for Pinniped Supervisor/JWTAuthenticator end-to-end flow Dec 8, 2020
@ankeesler
Copy link
Contributor Author

I think @mattmoyer did this in #276 specifically in 0b38d6c.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant