UpstreamOIDCProvider has incorrect documentation about client secret type

[ankeesler]

What happened?

• I was reading the UpstreamOIDCProvider docs: https://github.com/vmware-tanzu/pinniped/tree/main/generated/1.19#k8s-api-go-pinniped-dev-generated-1-19-apis-supervisor-idp-v1alpha1-oidcclient.
• I noticed the docs said that the UpstreamOIDCProvider.spec.client.secretName type should be "secrets.pinniped.dev/oidc".
• However, the code expects secret type "secrets.pinniped.dev/oidc-client".

What did you expect to happen?

• The docs should refer to the correct secret type, "secrets.pinniped.dev/oidc-client".

What is the simplest way to reproduce this behavior?

• Look at the docs: https://github.com/vmware-tanzu/pinniped/tree/main/generated/1.19#k8s-api-go-pinniped-dev-generated-1-19-apis-supervisor-idp-v1alpha1-oidcclient.

In what environment did you see this bug?

• Pinniped server version:
• Pinniped client version:
• Pinniped container image (if using a public container image):
• Pinniped configuration (what IDP(s) are you using? what downstream credential minting mechanisms are you using?):
• Kubernetes version (use kubectl version):
• Kubernetes installer & version (e.g., kubeadm version):
• Cloud provider or hardware configuration:
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Others:

What else is there to know about this bug?