[1.10] Fix issue 6182 #6188
Merged
[1.10] Fix issue 6182 #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
blackpiglet
approved these changes
Apr 25, 2023
Codecov Report
@@ Coverage Diff @@
## release-1.10 #6188 +/- ##
================================================
- Coverage 40.68% 40.67% -0.01%
================================================
Files 244 244
Lines 21054 21057 +3
================================================
Hits 8565 8565
- Misses 11857 11860 +3
Partials 632 632
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qiuming-best
approved these changes
Apr 26, 2023
kaovilai
added a commit
to kaovilai/openshift-velero-plugin
that referenced
this pull request
Jul 12, 2023
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
added a commit
to kaovilai/openshift-velero-plugin
that referenced
this pull request
Jul 12, 2023
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
added a commit
to kaovilai/openshift-velero-plugin
that referenced
this pull request
Jul 12, 2023
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
added a commit
to kaovilai/openshift-velero-plugin
that referenced
this pull request
Jul 12, 2023
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> remove pod backup plugin from main.go
kaovilai
added a commit
to kaovilai/openshift-velero-plugin
that referenced
this pull request
Jul 12, 2023
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Remove non-working code for backing up completed build pods No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> remove pod backup plugin from main.go Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/openshift-velero-plugin
that referenced
this pull request
Aug 22, 2023
* add support for aws sts creds for registry Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * remove image-spec replace breaking build * OADP-1057: STS creds support for internal image backup Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Remove non-working code for backing up completed build pods No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> remove pod backup plugin from main.go * Resolve Dockerfile perm issues running go build by removing specified UID when copying Resolves ``` > [builder 6/6] RUN go build -installsuffix "static" -tags "containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp exclude_graphdriver_overlay include_gcs include_oss" -o _output/velero-plugins ./velero-plugins: #0 4.584 error obtaining VCS status: exit status 128 #0 4.584 Use -buildvcs=false to disable VCS stamping. ``` Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * update go.mod to openshift/velero #276 * add sts cred secret handling Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Pass secret path instead of web_identity_token_file Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Update go.mod to openshift/oadp-1.2 --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/openshift-velero-plugin
that referenced
this pull request
Aug 22, 2023
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> remove pod backup plugin from main.go
openshift-merge-robot
pushed a commit
to openshift/openshift-velero-plugin
that referenced
this pull request
Aug 22, 2023
…#202) * add support for aws sts creds for registry Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * remove image-spec replace breaking build * OADP-1057: STS creds support for internal image backup Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Remove non-working code for backing up completed build pods No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> remove pod backup plugin from main.go * Resolve Dockerfile perm issues running go build by removing specified UID when copying Resolves ``` > [builder 6/6] RUN go build -installsuffix "static" -tags "containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp exclude_graphdriver_overlay include_gcs include_oss" -o _output/velero-plugins ./velero-plugins: #0 4.584 error obtaining VCS status: exit status 128 #0 4.584 Use -buildvcs=false to disable VCS stamping. ``` Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * update go.mod to openshift/velero #276 * add sts cred secret handling Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Pass secret path instead of web_identity_token_file Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Update go.mod to openshift/oadp-1.2 --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Tiger Kaovilai <tkaovila@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #6182. If pod is not running, don't treat it as an error, let it go and leave a warning.