-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] govomi keepalive handler panic when login with token then login with basic auth #3206
Comments
@lubronzhan can you share a test that reproduces this? |
Hi @dougm I was adding saml support to CAPV. below are the link to the tests I just added loginbytoken func to It should login with bear token if userInfo is present, or login with saml sso if cert key pair are presented. If you want to run the spefific test, you can set
Thank you |
I tried your branch, I see a timeout failure, but not panic:
The branch diff and capv layers are a bit much to go through, can you reproduce with just govmomi? Such as by changing one of these tests? govmomi/session/keepalive/handler_test.go Line 56 in 72d86e9
Or: govmomi/session/keepalive/example_test.go Line 42 in 72d86e9
|
This issue is stale because it has been open for 90 days with no |
Describe the bug
A clear and concise description of what the bug is.
Goroutine panic when doing local testing with vcsim.
The test will first create a VC session using basic auth, then it will create a VC session with saml token.
Then govmomi keepalive handler will panic
https://github.com/vmware/govmomi/blob/main/session/keepalive/handler.go#L100-L133
To Reproduce
Steps to reproduce the behavior:
Expected behavior
session created with different auth func should coexsit
Affected version
Please provide details on the version used, e.g. release tag, commit, module version, etc.
0.30.7
Screenshots/Debug Output
If applicable, add screenshots or debug output to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: