Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Make startListeningOnPort() asynchronous #1

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Make startListeningOnPort() asynchronous #1

merged 1 commit into from
Apr 17, 2018

Conversation

hechaoli
Copy link
Contributor

Call addListener on server channel's close future instead of blocking on it.

@hechaoli hechaoli self-assigned this Apr 17, 2018
@vmwclabot
Copy link

@hechaoli, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Hechao Li <hechaol@outlook.com>
@coveralls
Copy link

coveralls commented Apr 17, 2018

Pull Request Test Coverage Report for Build 5

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 72.691%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ovsdb-client/src/main/java/com/vmware/ovsdb/service/impl/OvsdbPassiveConnectionListenerImpl.java 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
ovsdb-client/src/main/java/com/vmware/ovsdb/netty/OvsdbClientHandler.java 2 69.47%
ovsdb-client/src/main/java/com/vmware/ovsdb/service/impl/OvsdbPassiveConnectionListenerImpl.java 2 81.82%
Totals Coverage Status
Change from base Build 3: -0.2%
Covered Lines: 1291
Relevant Lines: 1776

💛 - Coveralls

@hechaoli hechaoli merged commit 4feb990 into vmware-archive:master Apr 17, 2018
@hechaoli hechaoli deleted the listen_async branch April 19, 2018 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants