Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Make listener and connector fully asynchronous. #4

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Make listener and connector fully asynchronous. #4

merged 1 commit into from
Apr 20, 2018

Conversation

hechaoli
Copy link
Contributor

  1. Return a Completable future instead of sync() on the bind() and connect()
    operations.
  2. The interface of active connector is also changed. Now it returns a
    CompleteableFuture of OvsdbClient object.

Signed-off-by: Hechao Li hechaol@outlook.com

1. Return a Completable future instead of sync() on the bind() and connect()
operations.
2. The interface of active connector is also changed. Now it returns a
CompleteableFuture of OvsdbClient object.

Signed-off-by: Hechao Li <hechaol@outlook.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12

  • 60 of 65 (92.31%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 74.791%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ovsdb-client/src/main/java/com/vmware/ovsdb/service/impl/OvsdbPassiveConnectionListenerImpl.java 28 33 84.85%
Totals Coverage Status
Change from base Build 11: 0.3%
Covered Lines: 1344
Relevant Lines: 1797

💛 - Coveralls

@hechaoli hechaoli merged commit faeb3fe into vmware-archive:master Apr 20, 2018
@hechaoli hechaoli deleted the async branch April 25, 2018 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants