Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove SDDC Manager root password dependency #113

Merged
merged 1 commit into from
Apr 10, 2023
Merged

refactor: remove SDDC Manager root password dependency #113

merged 1 commit into from
Apr 10, 2023

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Apr 6, 2023 •
edited
Loading

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Breaking: Updates Invoke-VcfHealthReport to use -localUser and localPass parameters instead of -SddcManagerRootPass. Examples use the local vcf user account for the SDDC Manager virtual appliance.
  • Breaking: Updates Publish-StorageCapacityHealth to use -localUser and localPass parameters instead of -rootPass. Examples use the local vcf user account for the SDDC Manager virtual appliance.
  • Breaking: Updates Request-SddcManagerStorageHealth to use -localUser and localPass parameters instead of -rootPass. Examples use the local vcf user account for the SDDC Manager virtual appliance.
  • Bumps the module version to v2.0.0.1005.
  • Updates CHANGELOG.md.

The -SddcManagerRootPass parameter is removed in 25f3c9f in favor of -localUser and -localPass to allow the user to provide the desired account.

The vcf account is used in the cmdlet examples. The root account can be used if desired.

cmdlet changes:

Publish-StorageCapacityHealth -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -localUser vcf -localPass VMw@re1! -allDomains

Request-SddcManagerStorageHealth -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -localUser vcf -localPass VMw@re1!

Invoke-VcfHealthReport -sddcManagerFqdn sfo-vcf01.sfo.rainpole.io -sddcManagerUser admin@local -sddcManagerPass VMw@re1!VMw@re1! -localUser vcf -localPass -reportPath F:\Reporting -allDomains

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #112
Related #89

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Documentation will be updated for the v2.0.0 release in separate pull request.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added breaking-change Breaking Change refactor Refactor labels Apr 6, 2023
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Apr 6, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 6, 2023 19:16
@tenthirtyam tenthirtyam force-pushed the refactor/remove-root-password-dependency- branch from 4f1e586 to df491b3 Compare April 6, 2023 19:17
@tenthirtyam tenthirtyam self-assigned this Apr 6, 2023
@tenthirtyam tenthirtyam marked this pull request as draft April 6, 2023 19:17
@tenthirtyam tenthirtyam force-pushed the refactor/remove-root-password-dependency- branch from df491b3 to d01579f Compare April 6, 2023 19:17
@tenthirtyam
refactor: remove SDDC Manager root password dependency
25f3c9f 
- **Breaking**: Updates `Invoke-VcfHealthReport` to use `-localUser` and `localPass` parameters instead of `-SddcManagerRootPass`. Examples use the local `vcf` user account for the SDDC Manager virtual appliance.
- **Breaking**: Updates `Publish-StorageCapacityHealth` to use `-localUser` and `localPass` parameters instead of `-rootPass`. Examples use the local `vcf` user account for the SDDC Manager virtual appliance.
- **Breaking**: Updates `Request-SddcManagerStorageHealth` to use `-localUser` and `localPass` parameters instead of `-rootPass`. Examples use the local `vcf` user account for the SDDC Manager virtual appliance.
- Bumps the module version to v2.0.0.1005.
- Updates `CHANGELOG.md`.

Closes #112
Related #89

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam force-pushed the refactor/remove-root-password-dependency- branch from d01579f to 25f3c9f Compare April 6, 2023 19:19
@tenthirtyam tenthirtyam marked this pull request as ready for review April 6, 2023 19:20
@tenthirtyam tenthirtyam added report/health Health Report technical-debt Technical Debt labels Apr 6, 2023
bhumitra
bhumitra approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@bhumitra bhumitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good. Ship it!

@tenthirtyam tenthirtyam merged commit 2ceb52a into main Apr 10, 2023
@tenthirtyam tenthirtyam deleted the refactor/remove-root-password-dependency- branch April 10, 2023 20:42
tenthirtyam added a commit that referenced this pull request Apr 12, 2023
@tenthirtyam
docs: update README.md
768e2fe 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam mentioned this pull request Apr 12, 2023
Merged
11 tasks
tenthirtyam added a commit that referenced this pull request Apr 12, 2023
@tenthirtyam
docs: update README.md
f72b563 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam added a commit that referenced this pull request Apr 13, 2023
@tenthirtyam
docs: update README.md
6719707 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam added a commit that referenced this pull request Apr 14, 2023
@tenthirtyam
docs: update README.md
0377598 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam added a commit that referenced this pull request Apr 18, 2023
@tenthirtyam
docs: update README.md
0b192f4 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam added a commit that referenced this pull request Apr 24, 2023
@tenthirtyam
docs: update README.md
133c16e 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam added a commit that referenced this pull request Apr 24, 2023
@tenthirtyam
docs: update README.md
22a1820 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113
- Updates `CHANGELOG.md` with v.2.0.0 release date.
- Updates the module GUID for v2.0.0.
- Updates the module version and build to 2.0.0.1007.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam added a commit that referenced this pull request Apr 25, 2023
@tenthirtyam @GaryJBlake
docs: update README.md (#119)
4b42c50 
- Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113
- Updates `CHANGELOG.md` with v.2.0.0 release date.
- Updates the module GUID for v2.0.0.
- Updates the module version and build to 2.0.0.1013.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Co-authored-by: Gary Blake <gblake@vmware.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bhumitra bhumitra bhumitra approved these changes

@GaryJBlake GaryJBlake Awaiting requested review from GaryJBlake

Assignees

@tenthirtyam tenthirtyam

Labels
breaking-change Breaking Change refactor Refactor report/health Health Report technical-debt Technical Debt
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Remove root password dependency from Publish-StorageCapacityHealth / Request-SddcManagerStorageHealth`
2 participants
@tenthirtyam @bhumitra