Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md #119

Merged
merged 3 commits into from
Apr 25, 2023
Merged

docs: update README.md #119

merged 3 commits into from
Apr 25, 2023

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Apr 12, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updates the README.md for the following:

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Ref: #113
Ref: #117
Ref: #118

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the documentation Documentation label Apr 12, 2023
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Apr 12, 2023
@tenthirtyam tenthirtyam self-assigned this Apr 12, 2023
@tenthirtyam tenthirtyam force-pushed the docs/update-readme branch 2 times, most recently from f72b563 to 6719707 Compare April 13, 2023 13:36
@tenthirtyam tenthirtyam added the do-not-merge Do Not Merge label Apr 13, 2023
@tenthirtyam tenthirtyam marked this pull request as ready for review April 13, 2023 14:11
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 13, 2023 14:11
@tenthirtyam tenthirtyam force-pushed the docs/update-readme branch 2 times, most recently from 0377598 to 0b192f4 Compare April 18, 2023 17:15
@tenthirtyam tenthirtyam removed the do-not-merge Do Not Merge label Apr 20, 2023
@tenthirtyam tenthirtyam requested review from GaryJBlake and removed request for GaryJBlake April 24, 2023 15:59
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113
- Updates `CHANGELOG.md` with v.2.0.0 release date.
- Updates the module GUID for v2.0.0.
- Updates the module version and build to 2.0.0.1007.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Signed-off-by: Gary Blake <gblake@vmware.com>
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vmwclabot
Copy link
Member

@tenthirtyam, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Apr 25, 2023
Signed-off-by: Gary Blake <gblake@vmware.com>
GaryJBlake
GaryJBlake previously approved these changes Apr 25, 2023
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake dismissed their stale review April 25, 2023 06:48

Already approved

Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit 4b42c50 into main Apr 25, 2023
@tenthirtyam tenthirtyam deleted the docs/update-readme branch April 25, 2023 10:52
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants