refactor: update Invoke-VcfReportingPrereq cmdlet
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **Breaking**: Updates `Invoke-VcfReportingPrereq` to:
- Use the `-sddcManagerFqdn`, `sddcManagerUser`, and `sddcManagerPass` parameters to check the SDDC Manager version.
- Use the `Write-LogMessage` to apply colors to the output and log the output to a file using the `-logPath` parameter.
- Updates `PowerValidatedSolutions` from v2.0.1 to v2.2.0.
- Updates `VMware.PowerCLI` from v12.7.0 to v13.0.0.
- Updates `VMware.vSphere.SsoAdmin` from v1.3.8 to v1.3.9.
Closes #115
Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
force-pushed
the
refactor/prerequsites
branch
from
bc76a19
to
81d2cd2
Compare
tenthirtyam
requested review from
bhumitra and
GaryJBlake
and removed request for
a team
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
Updates the `README.md` for the following: - Removes the Password Policy report. Ref: #118 - Updates the PowerShell module dependencies. Ref: #117 - Updates the minimum supported VMware Cloud Foundation version. Ref: #117 - Updates the use of `Test-VcfReportingPrereq`. Ref: #117 - Updates the use of `Invoke-VcfHealthReport`. Ref: #113 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
Updates the `README.md` for the following: - Removes the Password Policy report. Ref: #118 - Updates the PowerShell module dependencies. Ref: #117 - Updates the minimum supported VMware Cloud Foundation version. Ref: #117 - Updates the use of `Test-VcfReportingPrereq`. Ref: #117 - Updates the use of `Invoke-VcfHealthReport`. Ref: #113 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 13, 2023
Updates the `README.md` for the following: - Removes the Password Policy report. Ref: #118 - Updates the PowerShell module dependencies. Ref: #117 - Updates the minimum supported VMware Cloud Foundation version. Ref: #117 - Updates the use of `Test-VcfReportingPrereq`. Ref: #117 - Updates the use of `Invoke-VcfHealthReport`. Ref: #113 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 14, 2023
Updates the `README.md` for the following: - Removes the Password Policy report. Ref: #118 - Updates the PowerShell module dependencies. Ref: #117 - Updates the minimum supported VMware Cloud Foundation version. Ref: #117 - Updates the use of `Test-VcfReportingPrereq`. Ref: #117 - Updates the use of `Invoke-VcfHealthReport`. Ref: #113 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 18, 2023
Updates the `README.md` for the following: - Removes the Password Policy report. Ref: #118 - Updates the PowerShell module dependencies. Ref: #117 - Updates the minimum supported VMware Cloud Foundation version. Ref: #117 - Updates the use of `Test-VcfReportingPrereq`. Ref: #117 - Updates the use of `Invoke-VcfHealthReport`. Ref: #113 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 24, 2023
Updates the `README.md` for the following: - Removes the Password Policy report. Ref: #118 - Updates the PowerShell module dependencies. Ref: #117 - Updates the minimum supported VMware Cloud Foundation version. Ref: #117 - Updates the use of `Test-VcfReportingPrereq`. Ref: #117 - Updates the use of `Invoke-VcfHealthReport`. Ref: #113 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 24, 2023
Updates the `README.md` for the following: - Removes the Password Policy report. Ref: #118 - Updates the PowerShell module dependencies. Ref: #117 - Updates the minimum supported VMware Cloud Foundation version. Ref: #117 - Updates the use of `Test-VcfReportingPrereq`. Ref: #117 - Updates the use of `Invoke-VcfHealthReport`. Ref: #113 - Updates `CHANGELOG.md` with v.2.0.0 release date. - Updates the module GUID for v2.0.0. - Updates the module version and build to 2.0.0.1007. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 25, 2023
- Updates the `README.md` for the following: - Removes the Password Policy report. Ref: #118 - Updates the PowerShell module dependencies. Ref: #117 - Updates the minimum supported VMware Cloud Foundation version. Ref: #117 - Updates the use of `Test-VcfReportingPrereq`. Ref: #117 - Updates the use of `Invoke-VcfHealthReport`. Ref: #113 - Updates `CHANGELOG.md` with v.2.0.0 release date. - Updates the module GUID for v2.0.0. - Updates the module version and build to 2.0.0.1013. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com> Co-authored-by: Gary Blake <gblake@vmware.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Invoke-VcfReportingPrereqto: - Use the-sddcManagerFqdn,sddcManagerUser, andsddcManagerPassparameters to check the SDDC Manager version. - Use theWrite-LogMessageto apply colors to the output and log the output to a file using the-logPathparameter.PowerValidatedSolutionsfrom v2.0.1 to v2.2.0.VMware.PowerCLIfrom v12.7.0 to v13.0.0.VMware.vSphere.SsoAdminfrom v1.3.8 to v1.3.9.Type of Pull Request
Please describe:
Related to Existing Issues
Closes #115
Test and Documentation Coverage
Windows PowerShell 5.1 on Windows Server 2019
PowerShell Core 7.3 on VMware Photon OS 4.0
Documentation will be updated for the v2.0.0 release in separate pull request.
Breaking Changes?