This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Make "Redirect Github webhooks" step mandatory #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
======================================
Coverage 98.3% 98.3%
======================================
Files 18 18
Lines 355 355
Branches 38 38
======================================
Hits 349 349
Misses 6 6Continue to review full report at Codecov.
|
joshuagl
suggested changes
Sep 19, 2019
In our doc "Setting up a manual deployment" we didn't emphasize how important it is to redirect the GitHub webhooks to your local machine. Without this step you can't see how Precaution actually works! Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
joshuagl
approved these changes
Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our doc "Setting up a manual deployment" we didn't emphasize
how important it is to redirect the GitHub webhooks to your local
machine.
Without this step you can't see how Precaution actually works!
Signed-off-by: Martin Vrachev mvrachev@vmware.com